Bug Fix: Adds validity round check for failing tests

[AlgoStephenAkiki]

Resolves #2088

Currently these tests are failing:

TestParticipationAccountsExpirationFuture
TestParticipationAccountsExpirationNonFuture

Add validity round checks so that rounds are appropriately set when generating the registration transaction.

[algorandskiy]

The issue linked does not look to be a correct one. I suggest to put a better description into the PR

[codecov]

Codecov Report

Merging #4085 (81e2cac) into master (febeb1e) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #4085      +/-   ##
==========================================
- Coverage   54.55%   54.49%   -0.06%     
==========================================
  Files         391      391              
  Lines       48662    48668       +6     
==========================================
- Hits        26546    26524      -22     
- Misses      19890    19921      +31     
+ Partials     2226     2223       -3     

Impacted Files	Coverage Δ
libgoal/transactions.go	0.00% <0.00%> (ø)
agreement/cryptoVerifier.go	67.60% <0.00%> (-2.12%)	⬇️
agreement/proposalManager.go	96.07% <0.00%> (-1.97%)	⬇️
node/node.go	22.42% <0.00%> (-1.87%)	⬇️
data/transactions/verify/txn.go	44.15% <0.00%> (-0.87%)	⬇️
catchup/service.go	69.38% <0.00%> (-0.75%)	⬇️
ledger/acctupdates.go	68.77% <0.00%> (-0.66%)	⬇️
network/wsNetwork.go	64.79% <0.00%> (-0.48%)	⬇️
network/wsPeer.go	68.49% <0.00%> (ø)
data/abi/abi_type.go	88.62% <0.00%> (+0.94%)	⬆️
... and 2 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update febeb1e...81e2cac. Read the comment docs.

[AlgoStephenAkiki]

The issue linked does not look to be a correct one. I suggest to put a better description into the PR

Updated.

[algorandskiy]

Run at 02dfe12

go test ./test/e2e-go/features/participation -run TestParticipationAccountsExpirationFuture

ok  	github.com/algorand/go-algorand/test/e2e-go/features/participation	66.944s

go test ./test/e2e-go/features/participation -run TestParticipationAccountsExpirationNonFuture

    testingLogger.go:38: time="2022-06-07T13:00:07.905767 -0400" level=error msg="first valid: 0, last valid: 12, current round: 2" file=participationExpiration_test.go function=github.com/algorand/go-algorand/test/e2e-go/features/participation.testExpirationAccounts line=103
    fixture.go:119: 
        	Error Trace:	participationExpiration_test.go:104
        	            				participationExpiration_test.go:217
        	Error:      	Received unexpected error:

[algorandskiy]

with the recent fix the second test passed as well

go test ./test/e2e-go/features/participation -run TestParticipationAccountsExpirationNonFuture
ok  	github.com/algorand/go-algorand/test/e2e-go/features/participation	67.334s

[algorandskiy]

@winder please take a look as well

[winder]

LGTM. Thanks @AlgoStephenAkiki