AVM: Version downgrade check ported to master #4093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmalouf
commented
Jun 8, 2022
| @@ -726,9 +726,9 @@ func ProgramVersion(bytecode []byte) (version uint64, length int, err error) { | |||
| // matching versions between approval and clearstate. | |||
| const syncProgramsVersion = 6 | |||
|
|
|||
| // CheckContractVersions ensures that for v6 and higher two programs are version | |||
There was a problem hiding this comment.
@jannotti see if this wording works or feel free to adjust inline on the branch.
gmalouf
changed the title
Codecov Report
@@ Coverage Diff @@
## master #4093 +/- ##
==========================================
- Coverage 54.46% 54.46% -0.01%
==========================================
Files 391 391
Lines 48668 48668
==========================================
- Hits 26508 26505 -3
- Misses 19934 19937 +3
Partials 2226 2226
Continue to review full report at Codecov.
|
jannotti
previously approved these changes
Jun 8, 2022
Co-authored-by: John Jannotti <[email protected]>
Co-authored-by: John Jannotti <[email protected]>
Co-authored-by: John Jannotti <[email protected]>
Co-authored-by: John Jannotti <[email protected]>
jannotti
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Applied JJ's fix for inner app downgrade version checking along with minor comment tweaks.