Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVM: Set proper costs for json_ref #4096

Merged
merged 19 commits into from
Jun 8, 2022
Merged

Conversation

jannotti
Copy link
Contributor

@jannotti jannotti commented Jun 8, 2022

Made from Jacob's branch to fix a lint error while he's out.

jdtzmn added 18 commits May 31, 2022 15:38
* Cuts json_ref running time in roughly half
* Allows for duplicate keys. Always choose the value of the first seen key
It previously seemed that Algorand’s JSON parser did not detect duplicate keys but since it does raise an error, there is seemingly no meaningful reason not to indicate within json_ref when duplicates are found.
Use stack label for linear cost depth doc
@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #4096 (4da6b6f) into master (7147d01) will increase coverage by 0.01%.
The diff coverage is 84.37%.

@@            Coverage Diff             @@
##           master    #4096      +/-   ##
==========================================
+ Coverage   54.49%   54.50%   +0.01%     
==========================================
  Files         390      390              
  Lines       48620    48621       +1     
==========================================
+ Hits        26497    26503       +6     
+ Misses      19902    19891      -11     
- Partials     2221     2227       +6     
Impacted Files Coverage Δ
data/transactions/logic/opcodes.go 83.76% <50.00%> (-1.11%) ⬇️
data/transactions/logic/eval.go 89.82% <95.45%> (+0.21%) ⬆️
data/transactions/logic/doc.go 61.53% <100.00%> (+1.53%) ⬆️
ledger/roundlru.go 90.56% <0.00%> (-5.67%) ⬇️
ledger/blockqueue.go 82.18% <0.00%> (-2.88%) ⬇️
ledger/tracker.go 74.45% <0.00%> (-2.17%) ⬇️
ledger/acctupdates.go 68.77% <0.00%> (-1.06%) ⬇️
network/wsNetwork.go 65.27% <0.00%> (+0.28%) ⬆️
network/wsPeer.go 68.76% <0.00%> (+0.54%) ⬆️
catchup/service.go 68.88% <0.00%> (+0.74%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7147d01...4da6b6f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement vFuture Proposed for a future protocol upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants