-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AVM: Set proper costs for json_ref #4096
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Cuts json_ref running time in roughly half * Allows for duplicate keys. Always choose the value of the first seen key
It previously seemed that Algorand’s JSON parser did not detect duplicate keys but since it does raise an error, there is seemingly no meaningful reason not to indicate within json_ref when duplicates are found.
Use stack label for linear cost depth doc
…key is not found
jasonpaulos
approved these changes
Jun 8, 2022
Codecov Report
@@ Coverage Diff @@
## master #4096 +/- ##
==========================================
+ Coverage 54.49% 54.50% +0.01%
==========================================
Files 390 390
Lines 48620 48621 +1
==========================================
+ Hits 26497 26503 +6
+ Misses 19902 19891 -11
- Partials 2221 2227 +6
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made from Jacob's branch to fix a lint error while he's out.