-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Goal: Fix source map mappings key and use relative line values #4198
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@algochoi Thanks for your efforts to address sourcemap spec deviations. ☕
Codecov Report
@@ Coverage Diff @@
## master #4198 +/- ##
==========================================
+ Coverage 54.55% 54.59% +0.03%
==========================================
Files 391 391
Lines 48788 48790 +2
==========================================
+ Hits 26617 26636 +19
+ Misses 19947 19935 -12
+ Partials 2224 2219 -5
Continue to review full report at Codecov.
|
Summary
This PR deprecates the previous
mapping
field and adds themappings
field to align itself closer to the sourcemap specs. In addition, it fixes the mappings so that it uses relative line values for the source line mapping.Closes #4191 #4192
Test Plan
Added test to check the new field in the source map.