Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Remove unused newAcctUpdates parameter: dbPathPrefix #4353

Merged
merged 1 commit into from
Aug 4, 2022

Conversation

michaeldiamant
Copy link
Contributor

@michaeldiamant michaeldiamant commented Aug 4, 2022

Summary

Makes these changes to newAcctUpdates:

  • Remove unused parameter: dbPathPrefix. Since the method is test-only and all usages rely on ".", I'm guessing customization is not needed. If the preference is to use the parameter, let me know.
  • Require no error during l.trackers.initialize. It seemed prudent to check the returned error.

I considered these changes while reviewing #4275. Consider the PR optional. If folks don't think it's worth pulling in, I'll happily close it.

Test Plan

gotestsum -- ./ledger

@michaeldiamant michaeldiamant changed the title Remove unused newAcctUpdates parameter: dbPathPrefix Tests: Remove unused newAcctUpdates parameter: dbPathPrefix Aug 4, 2022
@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #4353 (6ee5542) into master (7a56ea7) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4353      +/-   ##
==========================================
+ Coverage   55.23%   55.26%   +0.02%     
==========================================
  Files         395      395              
  Lines       50352    50352              
==========================================
+ Hits        27811    27826      +15     
+ Misses      20149    20133      -16     
- Partials     2392     2393       +1     
Impacted Files Coverage Δ
ledger/roundlru.go 90.56% <0.00%> (-5.67%) ⬇️
data/abi/abi_type.go 87.67% <0.00%> (-0.95%) ⬇️
data/transactions/verify/txn.go 44.00% <0.00%> (-0.89%) ⬇️
catchup/service.go 70.12% <0.00%> (ø)
network/wsNetwork.go 65.17% <0.00%> (+0.28%) ⬆️
ledger/acctupdates.go 70.52% <0.00%> (+0.60%) ⬆️
catchup/peerSelector.go 100.00% <0.00%> (+1.04%) ⬆️
util/db/dbutil.go 50.30% <0.00%> (+1.21%) ⬆️
ledger/tracker.go 78.63% <0.00%> (+1.28%) ⬆️
network/wsPeer.go 67.67% <0.00%> (+2.19%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@michaeldiamant michaeldiamant marked this pull request as ready for review August 4, 2022 02:09
@michaeldiamant michaeldiamant merged commit a7ed845 into algorand:master Aug 4, 2022
@michaeldiamant michaeldiamant deleted the rm_unused_param branch August 4, 2022 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants