tests: Add logging to libgoal fixture on failure #4384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
ghost
requested a review
from | @@ -324,6 +328,22 @@ func (f *LibGoalFixture) ShutdownImpl(preserveData bool) { | |||
| } | |||
| } | |||
|
|
|||
| // dumpLogs prints out node.log files for the running nodes | |||
| func (f *LibGoalFixture) dumpLogs(dataDir string) { | |||
| file, err := os.Open(dataDir + "/node.log") | |||
There was a problem hiding this comment.
please limit to ~100 lines, and dump algod-err.log and algod-out.log if not empty as well
| f.t.Logf("txn failed to confirm: ", addr, txid) | ||
| pendingTxns, err := f.AlgodClient.GetPendingTransactions(0) | ||
| if err == nil { | ||
| f.t.Logf("pending: ", pendingTxns) |
There was a problem hiding this comment.
let's print out both lists of txnids - txidsAndAddresses and pending
Codecov Report
@@ Coverage Diff @@
## master #4384 +/- ##
==========================================
- Coverage 55.63% 55.59% -0.04%
==========================================
Files 403 403
Lines 50805 50805
==========================================
- Hits 28263 28246 -17
- Misses 20148 20165 +17
Partials 2394 2394
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| @@ -311,6 +312,10 @@ func (f *LibGoalFixture) ShutdownImpl(preserveData bool) { | |||
| f.NC.StopKMD() | |||
| if preserveData { | |||
| f.network.Stop(f.binDir) | |||
| f.dumpLogs(f.PrimaryDataDir() + "/node.log") | |||
There was a problem hiding this comment.
since we kind of unofficially support Windows, could you also use filepath.Join(f.PrimaryDataDir(), "node.log") instead here and below?
algorandskiy
approved these changes
Aug 11, 2022
Co-authored-by: Pavel Zbitskiy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When a test running the libgoal fixture, flakes, it is difficult for us to diagnose the problem. Print out node.log to the test console so we can analyze the problem.
Test Plan
Purposely failed test to check whether logs were dumped.