Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Four missing partiontest calls. And minor doc update. #4394

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

jannotti
Copy link
Contributor

We were missing some partitiontest calls. I don't know why the checking didn't fail. It DID see the problem
Screen Shot 2022-08-11 at 9 38 45 AM

It seems to me that a) The linter was supposed to complain. and b) the test checker should have failed.

@jannotti jannotti changed the title Four missing partiontest calls. And minor doc update. CI: Four missing partiontest calls. And minor doc update. Aug 11, 2022
@jannotti jannotti requested review from algorandskiy and cce and removed request for algorandskiy August 11, 2022 14:02
@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #4394 (2395b5e) into master (701d431) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4394      +/-   ##
==========================================
- Coverage   55.63%   55.57%   -0.06%     
==========================================
  Files         403      403              
  Lines       50805    50805              
==========================================
- Hits        28263    28235      -28     
- Misses      20148    20170      +22     
- Partials     2394     2400       +6     
Impacted Files Coverage Δ
data/transactions/logic/doc.go 61.53% <ø> (ø)
ledger/blockqueue.go 85.63% <0.00%> (-2.88%) ⬇️
ledger/tracker.go 77.77% <0.00%> (-2.57%) ⬇️
crypto/merkletrie/trie.go 66.42% <0.00%> (-2.19%) ⬇️
crypto/merkletrie/node.go 91.62% <0.00%> (-1.87%) ⬇️
util/db/dbutil.go 49.09% <0.00%> (-1.22%) ⬇️
data/abi/abi_type.go 87.67% <0.00%> (-0.95%) ⬇️
catchup/service.go 69.38% <0.00%> (-0.75%) ⬇️
ledger/acctonline.go 78.47% <0.00%> (-0.53%) ⬇️
network/requestTracker.go 71.12% <0.00%> (-0.44%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jannotti jannotti marked this pull request as ready for review August 11, 2022 15:20
@algorandskiy algorandskiy merged commit 7c70e38 into algorand:master Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants