Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Acquire locks when logging start and stop. #4408

Merged
merged 1 commit into from
Aug 15, 2022

Conversation

jannotti
Copy link
Contributor

CI false negative seemed to be, actually, a false false negative, caused when the gotestsum command was unable to parse the json file created by e2e_client_runner That is likely because it was being written to by concurrent threads.

@jannotti jannotti changed the title Acquire locks when logging start and stop. Test: Acquire locks when logging start and stop. Aug 13, 2022
@codecov
Copy link

codecov bot commented Aug 13, 2022

Codecov Report

Merging #4408 (42e10b1) into master (ee302b0) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4408      +/-   ##
==========================================
- Coverage   55.57%   55.52%   -0.05%     
==========================================
  Files         400      400              
  Lines       50797    50797              
==========================================
- Hits        28229    28205      -24     
- Misses      20169    20189      +20     
- Partials     2399     2403       +4     
Impacted Files Coverage Δ
ledger/roundlru.go 90.56% <0.00%> (-5.67%) ⬇️
network/wsPeer.go 65.47% <0.00%> (-3.02%) ⬇️
crypto/merkletrie/trie.go 66.42% <0.00%> (-2.19%) ⬇️
crypto/merkletrie/node.go 91.62% <0.00%> (-1.87%) ⬇️
cmd/tealdbg/debugger.go 72.69% <0.00%> (-0.81%) ⬇️
util/db/dbutil.go 43.63% <0.00%> (-0.61%) ⬇️
ledger/acctupdates.go 69.92% <0.00%> (-0.61%) ⬇️
ledger/acctonline.go 78.47% <0.00%> (-0.53%) ⬇️
network/wsNetwork.go 64.89% <0.00%> (+0.19%) ⬆️
catchup/service.go 68.64% <0.00%> (+0.49%) ⬆️
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jannotti jannotti marked this pull request as ready for review August 13, 2022 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants