-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ledger: do not shadow db error in account lookup #4425
ledger: do not shadow db error in account lookup #4425
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4425 +/- ##
==========================================
+ Coverage 55.13% 55.16% +0.03%
==========================================
Files 397 397
Lines 50073 50079 +6
==========================================
+ Hits 27607 27627 +20
+ Misses 20170 20156 -14
Partials 2296 2296
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - should give us the more important error detail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed CR feedback
f840fb3
to
996ffbf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Summary
DB lookup might fail and acctupdates' lookup method return not original error but overwritten by another one.
This makes debugging a bit harder.
Test Plan
Existing tests