testing: deterministic rand seed for stable unit test #4447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpcs/txSyncer_test.go
Outdated
| testRand = rand.New(testSource) | ||
| } | ||
|
|
||
| func cryptoRandBytes(d []byte) { |
There was a problem hiding this comment.
mb call it just randBytes ?
There was a problem hiding this comment.
changed to testRandBytes()
Codecov Report
@@ Coverage Diff @@
## master #4447 +/- ##
==========================================
+ Coverage 55.19% 55.21% +0.01%
==========================================
Files 398 398
Lines 50165 50165
==========================================
+ Hits 27689 27698 +9
+ Misses 20159 20155 -4
+ Partials 2317 2312 -5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
algorandskiy
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Putting random data into a bloom filter would sometimes fail the test. Set the random seed so that we have deterministic psuedo-random data.
Test Plan
Ran this for a while with no errors. Used to fail within a few dozen tries.
go test -c -race -o rpcs.test && while logwrapq ./rpcs.test -test.count 50 -test.timeout 5m -test.v -test.run TestSync; do date; done