Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Increase parallelism without changing resource_class for faster builds #4448

Merged
merged 20 commits into from
Aug 25, 2022

Conversation

michaeldiamant
Copy link
Contributor

Provides an alternative to #4427 that cuts estimated costs by ~50% in exchange for longer build durations.

Based on the sample run times in https://app.circleci.com/pipelines/github/algorand/go-algorand?branch=circleci_consolidate_parallelism_alt, we can expect build durations of ~18-22min.

@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #4448 (e0ff19d) into circleci_consolidate_parallelism (a311590) will increase coverage by 0.02%.
The diff coverage is n/a.

@@                         Coverage Diff                          @@
##           circleci_consolidate_parallelism    #4448      +/-   ##
====================================================================
+ Coverage                             55.22%   55.25%   +0.02%     
====================================================================
  Files                                   398      398              
  Lines                                 50165    50165              
====================================================================
+ Hits                                  27706    27721      +15     
+ Misses                                20138    20128      -10     
+ Partials                               2321     2316       -5     
Impacted Files Coverage Δ
catchup/service.go 69.38% <0.00%> (-1.73%) ⬇️
ledger/tracker.go 74.78% <0.00%> (ø)
ledger/accountdb.go 72.74% <0.00%> (+0.15%) ⬆️
ledger/acctonline.go 79.41% <0.00%> (+0.52%) ⬆️
network/requestTracker.go 71.12% <0.00%> (+0.86%) ⬆️
network/wsPeer.go 71.23% <0.00%> (+3.01%) ⬆️
ledger/roundlru.go 96.22% <0.00%> (+5.66%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@michaeldiamant
Copy link
Contributor Author

Basing off of master rather than #4427. Based on live discussion, we agreed to favor this PR over #4427.

@michaeldiamant michaeldiamant changed the base branch from circleci_consolidate_parallelism to master August 24, 2022 15:21
@michaeldiamant michaeldiamant marked this pull request as ready for review August 24, 2022 15:21
@michaeldiamant michaeldiamant requested review from cce and jannotti August 24, 2022 15:22
@michaeldiamant michaeldiamant changed the title Scale test and e2e_expect back to resource_class = medium CI: Scale test and e2e_expect back to resource_class = medium Aug 24, 2022
@michaeldiamant michaeldiamant changed the title CI: Scale test and e2e_expect back to resource_class = medium CI: Increase parallelism without changing resource_class for faster builds Aug 25, 2022
Copy link
Contributor

@jannotti jannotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is what we agreed to.

@cce cce requested review from a team, egieseke, algobarb and algolucky August 25, 2022 14:23
Copy link
Contributor

@algojack algojack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants