Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e tests: tag e2e test data with commit hash #4481

Merged
merged 2 commits into from
Aug 29, 2022

Conversation

shiqizng
Copy link
Contributor

@shiqizng shiqizng commented Aug 26, 2022

Summary

This is for resolving #1174. Another copy of rel/nightly e2e artifact is uploaded to file path algorand-testdata/indexer/e2e4/<commit_hash>/. This way, indexer's e2e test can use data generated from a specific version of go-algorand.

Test Plan

check that data is created in s3 with correct file path.

@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #4481 (35b2bdc) into master (e4d6d42) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4481      +/-   ##
==========================================
- Coverage   55.19%   55.17%   -0.02%     
==========================================
  Files         398      398              
  Lines       50165    50165              
==========================================
- Hits        27689    27680       -9     
- Misses      20159    20169      +10     
+ Partials     2317     2316       -1     
Impacted Files Coverage Δ
util/db/dbutil.go 44.24% <0.00%> (-4.25%) ⬇️
ledger/blockqueue.go 84.48% <0.00%> (-1.15%) ⬇️
ledger/tracker.go 73.93% <0.00%> (-0.86%) ⬇️
ledger/acctupdates.go 69.29% <0.00%> (-0.60%) ⬇️
ledger/acctonline.go 78.36% <0.00%> (-0.53%) ⬇️
catchup/service.go 68.88% <0.00%> (-0.50%) ⬇️
crypto/merkletrie/node.go 93.48% <0.00%> (+1.86%) ⬆️
crypto/merkletrie/trie.go 68.61% <0.00%> (+2.18%) ⬆️
ledger/roundlru.go 96.22% <0.00%> (+5.66%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@algorandskiy algorandskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR/commit headline: enhancement: -> component name. In this case tests: or e2e tests:, or something else

@shiqizng shiqizng changed the title enhancement: tag e2e test data with commit hash e2e tests: tag e2e test data with commit hash Aug 29, 2022
@shiqizng shiqizng requested a review from algorandskiy August 29, 2022 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants