Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: create filtered TagCounters from init #4524

Merged
merged 1 commit into from
Sep 9, 2022

Conversation

cce
Copy link
Contributor

@cce cce commented Sep 9, 2022

Summary

This ensures the tag list is passed to the filtered TagCounters.

Test Plan

Existing tests should pass.

@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #4524 (730029b) into master (16c4c93) will decrease coverage by 0.69%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4524      +/-   ##
==========================================
- Coverage   54.04%   53.34%   -0.70%     
==========================================
  Files         401      401              
  Lines       51536    51540       +4     
==========================================
- Hits        27852    27495     -357     
- Misses      21351    21683     +332     
- Partials     2333     2362      +29     
Impacted Files Coverage Δ
network/wsPeer.go 66.03% <100.00%> (+0.37%) ⬆️
util/uuid/uuid.go 0.00% <0.00%> (-81.82%) ⬇️
cmd/goal/inspect.go 0.00% <0.00%> (-70.18%) ⬇️
cmd/tealdbg/remote.go 15.38% <0.00%> (-61.54%) ⬇️
network/multiplexer.go 70.58% <0.00%> (-20.59%) ⬇️
cmd/algocfg/getCommand.go 12.00% <0.00%> (-16.00%) ⬇️
agreement/proposalManagerContract.go 42.85% <0.00%> (-14.29%) ⬇️
data/ledger.go 17.51% <0.00%> (-13.87%) ⬇️
rpcs/blockService.go 52.11% <0.00%> (-12.68%) ⬇️
data/basics/units.go 48.00% <0.00%> (-12.00%) ⬇️
... and 44 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cce cce merged commit cb4219d into algorand:master Sep 9, 2022
@cce cce deleted the init-wspeer-tagcounters branch September 9, 2022 20:27
onetechnical pushed a commit to onetechnical/go-algorand that referenced this pull request Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants