Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Move box test artifacts to a temp directory #4771

Merged
merged 3 commits into from
Nov 8, 2022

Conversation

algochoi
Copy link
Contributor

@algochoi algochoi commented Nov 8, 2022

Summary

This PR creates the intermediate box transaction artifacts in a temp directory, which can be cleaned up later. Currently, the artifacts are created in the root directory.

Test Plan

CI Tests.

@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Merging #4771 (bff4723) into master (5c97463) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4771      +/-   ##
==========================================
- Coverage   54.59%   54.58%   -0.01%     
==========================================
  Files         414      414              
  Lines       53646    53646              
==========================================
- Hits        29286    29284       -2     
+ Misses      21935    21934       -1     
- Partials     2425     2428       +3     
Impacted Files Coverage Δ
crypto/merkletrie/trie.go 66.42% <0.00%> (-2.19%) ⬇️
network/wsPeer.go 66.50% <0.00%> (-1.95%) ⬇️
crypto/merkletrie/node.go 91.62% <0.00%> (-1.87%) ⬇️
catchup/service.go 68.88% <0.00%> (ø)
cmd/tealdbg/debugger.go 73.49% <0.00%> (+0.80%) ⬆️
ledger/tracker.go 78.72% <0.00%> (+4.68%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@michaeldiamant michaeldiamant marked this pull request as ready for review November 8, 2022 17:27
@michaeldiamant michaeldiamant merged commit e6172bc into algorand:master Nov 8, 2022
@algochoi algochoi deleted the delete-boxtest-artifacts branch November 8, 2022 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants