Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ledger: move migrations into a storage package (7 of N) #4846

Merged
merged 4 commits into from
Dec 7, 2022

Conversation

icorderi
Copy link
Contributor

@icorderi icorderi commented Dec 1, 2022

Summary

This PR moves the database creation and migration into the store package.

Previous parts of this refactor:

What remains to be moved out:

  • setup stuff
    • table/index creations
    • table deletions
    • migrations
  • iterators
    • orderedAccountsIter
    • catchpointPendingHashesIterator
  • deltas
    • accountsLoadOld and resourcesLoadOld have a couple queries that we might want to move out to avoid pulling all the deltas into store

Test Plan

Existing tests.

@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Merging #4846 (a70260d) into master (a70260d) will not change coverage.
The diff coverage is n/a.

❗ Current head a70260d differs from pull request most recent head ba2e765. Consider uploading reports for the commit ba2e765 to get more accurate results

@@           Coverage Diff           @@
##           master    #4846   +/-   ##
=======================================
  Coverage   53.30%   53.30%           
=======================================
  Files         422      422           
  Lines       53699    53699           
=======================================
  Hits        28624    28624           
  Misses      22799    22799           
  Partials     2276     2276           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@icorderi icorderi force-pushed the refactor/accountdb-7 branch from edb121d to c149810 Compare December 1, 2022 21:05
@icorderi icorderi changed the title refactor: accountdb.go into a store package (6 of N) refactor: accountdb.go into a store package (7 of N) Dec 2, 2022
@algorandskiy algorandskiy merged commit 00cf6be into algorand:master Dec 7, 2022
@algorandskiy algorandskiy changed the title refactor: accountdb.go into a store package (7 of N) ledger: move migrations into a storage package (7 of N) Dec 7, 2022
@icorderi icorderi deleted the refactor/accountdb-7 branch December 16, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants