Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix dependency on global counters #4921

Merged
merged 7 commits into from
Dec 17, 2022

Conversation

algonautshant
Copy link
Contributor

@algonautshant algonautshant commented Dec 17, 2022

These tests depend on global counters. Depending on the order of the tests running, they might interfere with each other, or interfere with parallel running tests.

This change forces such tests not to run in parallel, and initializes and resets the global counters.

In addition, cleanup of resources (ledger close, exec pool shutdown) which are not returned when the tests finish and consume memory and threads unnecessarily.

@algonautshant algonautshant force-pushed the shant/multisig_benchmark branch from cbc7c2a to d4bf6e0 Compare December 17, 2022 03:31
@algorandskiy algorandskiy changed the title enhancement: Fixx tests dependent on global counters tests: fix dependency on global counters Dec 17, 2022
algorandskiy
algorandskiy previously approved these changes Dec 17, 2022
@codecov
Copy link

codecov bot commented Dec 17, 2022

Codecov Report

Merging #4921 (cf43e3e) into master (89ed675) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4921      +/-   ##
==========================================
- Coverage   53.55%   53.53%   -0.02%     
==========================================
  Files         431      431              
  Lines       53533    53533              
==========================================
- Hits        28667    28660       -7     
- Misses      22643    22648       +5     
- Partials     2223     2225       +2     
Impacted Files Coverage Δ
ledger/blockqueue.go 85.63% <0.00%> (-2.88%) ⬇️
agreement/cryptoVerifier.go 67.60% <0.00%> (-2.12%) ⬇️
agreement/proposalManager.go 96.07% <0.00%> (-1.97%) ⬇️
catchup/peerSelector.go 98.95% <0.00%> (-1.05%) ⬇️
data/transactions/verify/txn.go 73.72% <0.00%> (-0.85%) ⬇️
ledger/testing/randomAccounts.go 56.61% <0.00%> (-0.62%) ⬇️
catchup/service.go 70.53% <0.00%> (ø)
network/wsNetwork.go 64.74% <0.00%> (ø)
ledger/tracker.go 75.10% <0.00%> (+0.84%) ⬆️
crypto/merkletrie/node.go 93.48% <0.00%> (+1.86%) ⬆️
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants