-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
util/s3: enable more credential providers #4929
util/s3: enable more credential providers #4929
Conversation
e31cf0d
to
8d0930f
Compare
8d0930f
to
c059238
Compare
c059238
to
d8620da
Compare
Codecov Report
@@ Coverage Diff @@
## master #4929 +/- ##
==========================================
- Coverage 53.51% 53.50% -0.01%
==========================================
Files 432 432
Lines 53615 53624 +9
==========================================
Hits 28691 28691
- Misses 22695 22702 +7
- Partials 2229 2231 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
4e97167
to
5b9cb3b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks much more clean now. What is the benefit of changing it to "only uses Anonymous credentials when communicating with algorand-releases" if bucket == s3DefaultReleaseBucket
?
@algobarb for this specific scenario:
This is just a shortcut so that whenever updater is dealing with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
67129e6
to
3c49eed
Compare
this will not be
live
untilupdate.sh
is updated to use the version this updater is released with, e.g.go-algorand/cmd/updater/update.sh
Line 4 in 026f0aa
Summary
updater
andgoal logging send
.s3.json
filealgorand-releases
Test Plan