node: Add logging thread to node monitoring wg #4934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4934 +/- ##
==========================================
+ Coverage 53.51% 53.53% +0.02%
==========================================
Files 432 432
Lines 53615 53616 +1
==========================================
+ Hits 28691 28706 +15
+ Misses 22695 22682 -13
+ Partials 2229 2228 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| @@ -399,6 +399,7 @@ func (node *AlgorandFullNode) startMonitoringRoutines() { | |||
| go node.oldKeyDeletionThread(node.ctx.Done()) | |||
|
|
|||
| if node.config.EnableUsageLog { | |||
| node.monitoringRoutinesWaitGroup.Add(1) | |||
There was a problem hiding this comment.
there is not corresponding monitoringRoutinesWaitGroup.Done()
There was a problem hiding this comment.
Ah you're right. It should be passed in via go logging.UsageLogThread(node.ctx, node.log, 100*time.Millisecond, node.monitoringRoutinesWaitGroup). I'm curious why we ended up passing nil instead.
algorandskiy
approved these changes
Dec 23, 2022
algorandskiy
approved these changes
Jan 6, 2023
winder
pushed a commit
to winder/go-algorand
that referenced
this pull request
Jan 18, 2023
This was referenced Jan 23, 2023
This was referenced Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit runs a goroutine without adding it to the monitoring wg.