Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e_subs: Remove unused Python cryptography package #4939

Merged
merged 3 commits into from
Dec 23, 2022

Conversation

michaeldiamant
Copy link
Contributor

@michaeldiamant michaeldiamant commented Dec 22, 2022

Removes an unused e2e_subs Python dependency: https://pypi.org/project/cryptography.

@michaeldiamant michaeldiamant changed the title Fix misspelled cryptography package reference e2e_subs: Fix misspelled cryptography package reference Dec 22, 2022
@michaeldiamant michaeldiamant marked this pull request as ready for review December 23, 2022 01:43
@michaeldiamant michaeldiamant requested review from tzaffi and removed request for tzaffi December 23, 2022 01:43
@michaeldiamant michaeldiamant marked this pull request as draft December 23, 2022 01:44
@algorandskiy
Copy link
Contributor

It's unclear to me how pip resolves cryptography

https://github.com/graingert/cryptograpy/blob/default/cryptograpy.py

this is an empty package, so maybe we do not need cryptography at all? All git grep cryptography entries are irrelevant.

@codecov
Copy link

codecov bot commented Dec 23, 2022

Codecov Report

Merging #4939 (ae8303b) into master (5363ae7) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4939      +/-   ##
==========================================
- Coverage   53.51%   53.50%   -0.01%     
==========================================
  Files         432      432              
  Lines       53624    53624              
==========================================
- Hits        28697    28693       -4     
  Misses      22701    22701              
- Partials     2226     2230       +4     
Impacted Files Coverage Δ
crypto/merkletrie/trie.go 66.42% <0.00%> (-2.19%) ⬇️
crypto/merkletrie/node.go 91.62% <0.00%> (-1.87%) ⬇️
catchup/service.go 69.08% <0.00%> (-1.45%) ⬇️
catchup/peerSelector.go 98.95% <0.00%> (-1.05%) ⬇️
data/transactions/verify/txn.go 73.72% <0.00%> (-0.85%) ⬇️
ledger/acctupdates.go 69.24% <0.00%> (-0.25%) ⬇️
ledger/tracker.go 78.90% <0.00%> (+0.84%) ⬆️
network/wsPeer.go 68.97% <0.00%> (+1.90%) ⬆️
ledger/blockqueue.go 88.50% <0.00%> (+2.87%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@michaeldiamant michaeldiamant marked this pull request as ready for review December 23, 2022 15:13
@michaeldiamant michaeldiamant changed the title e2e_subs: Fix misspelled cryptography package reference e2e_subs: Remove unused Python cryptography package Dec 23, 2022
@michaeldiamant
Copy link
Contributor Author

we do not need cryptography at all?

@algorandskiy Thanks for raising the question. I think you're right - The package is not used. I've updated the PR accordingly.

@algorandskiy algorandskiy merged commit 8966c69 into algorand:master Dec 23, 2022
@michaeldiamant michaeldiamant deleted the fix_typo branch December 23, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants