Tests: Fix t.Parallel() errors in data package

.golangci.yml

@@ -117,7 +117,7 @@ issues:
         - staticcheck
         - typecheck
     # Ignore missing parallel tests in existing packages
-    - path: (agreement|catchup|cmd|config|crypto|daemon|data|gen|ledger|logging|netdeploy|network|node|protocol|rpcs|shared|stateproof|test|tools|util).*_test\.go
+    - path: (agreement|catchup|cmd|config|crypto|daemon|gen|ledger|logging|netdeploy|network|node|protocol|rpcs|shared|stateproof|test|tools|util).*_test\.go
       linters:
         - paralleltest
     # Add all linters here -- Comment this block out for testing linters

data/account/participationRegistry_test.go

@@ -145,6 +145,7 @@ func registryCloseTest(t testing.TB, registry *participationDB, dbfilePrefix str
 // Insert participation records and make sure they can be fetched.
 func TestParticipation_InsertGet(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	t.Parallel()
 	a := require.New(t)
 	registry, dbfile := getRegistry(t)
 	defer registryCloseTest(t, registry, dbfile)
@@ -198,6 +199,7 @@ func TestParticipation_InsertGet(t *testing.T) {
 // Insert participation records and make sure they can be fetched.
 func TestParticipation_InsertGetWithoutEmptyStateproof(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	t.Parallel()
 	a := require.New(t)
 	registry, dbfile := getRegistry(t)
 	defer registryCloseTest(t, registry, dbfile)
@@ -238,6 +240,7 @@ func TestParticipation_InsertGetWithoutEmptyStateproof(t *testing.T) {
 // Make sure a record can be deleted by id.
 func TestParticipation_Delete(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	t.Parallel()
 	a := require.New(t)
 	registry, dbfile := getRegistryImpl(t, false, true) // inMem=false, erasable=true
 	defer registryCloseTest(t, registry, dbfile)
@@ -276,6 +279,7 @@ func (m testMessage) ToBeHashed() (protocol.HashID, []byte) {
 
 func TestParticipation_DeleteExpired(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	t.Parallel()
 	a := require.New(t)
 	registry, dbfile := getRegistryImpl(t, false, true) // inMem=false, erasable=true
 	defer registryCloseTest(t, registry, dbfile)
@@ -321,6 +325,7 @@ func TestParticipation_DeleteExpired(t *testing.T) {
 
 func TestParticipation_CleanupTablesAfterDeleteExpired(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	t.Parallel()
 	a := require.New(t)
 	registry, dbfile := getRegistryImpl(t, false, true) // inMem=false, erasable=true
 	defer registryCloseTest(t, registry, dbfile)
@@ -383,6 +388,7 @@ func TestParticipation_CleanupTablesAfterDeleteExpired(t *testing.T) {
 // Make sure the register function properly sets effective first/last for all effected records.
 func TestParticipation_Register(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	t.Parallel()
 	a := require.New(t)
 	registry, dbfile := getRegistry(t)
 	defer registryCloseTest(t, registry, dbfile)
@@ -421,6 +427,7 @@ func TestParticipation_Register(t *testing.T) {
 // Test error when registering a non-existing participation ID.
 func TestParticipation_RegisterInvalidID(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	t.Parallel()
 	a := require.New(t)
 	registry, dbfile := getRegistry(t)
 	defer registryCloseTest(t, registry, dbfile)
@@ -434,6 +441,7 @@ func TestParticipation_RegisterInvalidID(t *testing.T) {
 // Test error attempting to register a key with an invalid range.
 func TestParticipation_RegisterInvalidRange(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	t.Parallel()
 	a := require.New(t)
 	registry, dbfile := getRegistry(t)
 	defer registryCloseTest(t, registry, dbfile)
@@ -452,6 +460,7 @@ func TestParticipation_RegisterInvalidRange(t *testing.T) {
 // Test the recording function.
 func TestParticipation_Record(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	t.Parallel()
 	a := require.New(t)
 	registry, dbfile := getRegistry(t)
 	defer registryCloseTest(t, registry, dbfile)
@@ -506,6 +515,7 @@ func TestParticipation_Record(t *testing.T) {
 // Test that attempting to record an invalid action generates an error.
 func TestParticipation_RecordInvalidActionAndOutOfRange(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	t.Parallel()
 	a := require.New(t)
 	registry, dbfile := getRegistry(t)
 	defer registryCloseTest(t, registry, dbfile)
@@ -528,6 +538,7 @@ func TestParticipation_RecordInvalidActionAndOutOfRange(t *testing.T) {
 
 func TestParticipation_RecordNoKey(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	t.Parallel()
 	a := require.New(t)
 	registry, dbfile := getRegistry(t)
 	defer registryCloseTest(t, registry, dbfile)
@@ -540,6 +551,7 @@ func TestParticipation_RecordNoKey(t *testing.T) {
 // This would only happen if the DB was in an inconsistent state.
 func TestParticipation_RecordMultipleUpdates(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	t.Parallel()
 	a := require.New(t)
 	registry, dbfile := getRegistry(t)
 	defer registryCloseTest(t, registry, dbfile)
@@ -590,6 +602,7 @@ func TestParticipation_RecordMultipleUpdates(t *testing.T) {
 
 func TestParticipation_MultipleInsertError(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	t.Parallel()
 	a := require.New(t)
 	registry, dbfile := getRegistry(t)
 	defer registryCloseTest(t, registry, dbfile)
@@ -609,6 +622,7 @@ func TestParticipation_MultipleInsertError(t *testing.T) {
 // it should be detected as quickly as possible.
 func TestParticipation_RecordMultipleUpdates_DB(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	t.Parallel()
 	a := require.New(t)
 	registry, _ := getRegistry(t)
 
@@ -711,6 +725,7 @@ func TestParticipation_RecordMultipleUpdates_DB(t *testing.T) {
 
 func TestParticipation_NoKeyToUpdate(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	t.Parallel()
 	a := assert.New(t)
 	registry, dbfile := getRegistry(t)
 	defer registryCloseTest(t, registry, dbfile)
@@ -734,19 +749,20 @@ func TestParticipation_NoKeyToUpdate(t *testing.T) {
 // TestParticipion_Blobs adds some secrets to the registry and makes sure the same ones are returned.
 func TestParticipion_Blobs(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	t.Parallel()
 	a := require.New(t)
 	registry, dbfile := getRegistry(t)
 	defer registryCloseTest(t, registry, dbfile)
 
-	access, err := db.MakeAccessor("writetest_root", false, true)
+	access, err := db.MakeAccessor(t.Name()+"_writetest_root", false, true)
 	if err != nil {
 		panic(err)
 	}
 	root, err := GenerateRoot(access)
 	access.Close()
 	a.NoError(err)
 
-	access, err = db.MakeAccessor("writetest", false, true)
+	access, err = db.MakeAccessor(t.Name()+"_writetest", false, true)
 	if err != nil {
 		panic(err)
 	}
@@ -777,19 +793,20 @@ func TestParticipion_Blobs(t *testing.T) {
 // TestParticipion_EmptyBlobs makes sure empty blobs are set to nil
 func TestParticipion_EmptyBlobs(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	t.Parallel()
 	a := assert.New(t)
 	registry, dbfile := getRegistry(t)
 	defer registryCloseTest(t, registry, dbfile)
 
-	access, err := db.MakeAccessor("writetest_root", false, true)
+	access, err := db.MakeAccessor(t.Name()+"_writetest_root", false, true)
 	if err != nil {
 		panic(err)
 	}
 	root, err := GenerateRoot(access)
 	access.Close()
 	a.NoError(err)
 
-	access, err = db.MakeAccessor("writetest", false, true)
+	access, err = db.MakeAccessor(t.Name()+"_writetest", false, true)
 	if err != nil {
 		panic(err)
 	}
@@ -821,6 +838,7 @@ func TestParticipion_EmptyBlobs(t *testing.T) {
 
 func TestRegisterUpdatedEvent(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	t.Parallel()
 	a := require.New(t)
 	registry, dbfile := getRegistry(t)
 	defer registryCloseTest(t, registry, dbfile)
@@ -879,6 +897,7 @@ func TestFlushDeadlock(t *testing.T) {
 	var wg sync.WaitGroup
 
 	partitiontest.PartitionTest(t)
+	t.Parallel()
 	registry, dbfile := getRegistry(t)
 	defer registryCloseTest(t, registry, dbfile)
 
@@ -907,6 +926,7 @@ func TestFlushDeadlock(t *testing.T) {
 
 func TestAddStateProofKeys(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	t.Parallel()
 	a := require.New(t)
 	registry, dbfile := getRegistry(t)
 	defer registryCloseTest(t, registry, dbfile)
@@ -959,11 +979,12 @@ func TestAddStateProofKeys(t *testing.T) {
 
 func TestGetRoundSecretsWithNilStateProofVerifier(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	t.Parallel()
 	a := assert.New(t)
 	registry, dbfile := getRegistry(t)
 	defer registryCloseTest(t, registry, dbfile)
 
-	access, err := db.MakeAccessor("stateprooftest", false, true)
+	access, err := db.MakeAccessor(t.Name()+"_stateprooftest", false, true)
 	if err != nil {
 		panic(err)
 	}
@@ -989,6 +1010,7 @@ func TestGetRoundSecretsWithNilStateProofVerifier(t *testing.T) {
 
 func TestSecretNotFound(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	t.Parallel()
 	a := require.New(t)
 	registry, dbfile := getRegistry(t)
 	defer registryCloseTest(t, registry, dbfile)
@@ -1008,11 +1030,12 @@ func TestSecretNotFound(t *testing.T) {
 
 func TestAddingSecretTwice(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	t.Parallel()
 	a := assert.New(t)
 	registry, dbfile := getRegistry(t)
 	defer registryCloseTest(t, registry, dbfile)
 
-	access, err := db.MakeAccessor("stateprooftest", false, true)
+	access, err := db.MakeAccessor(t.Name()+"_stateprooftest", false, true)
 	if err != nil {
 		panic(err)
 	}
@@ -1046,11 +1069,12 @@ func TestAddingSecretTwice(t *testing.T) {
 
 func TestGetRoundSecretsWithoutStateProof(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	t.Parallel()
 	a := assert.New(t)
 	registry, dbfile := getRegistry(t)
 	defer registryCloseTest(t, registry, dbfile)
 
-	access, err := db.MakeAccessor("stateprooftest", false, true)
+	access, err := db.MakeAccessor(t.Name()+"_stateprooftest", false, true)
 	if err != nil {
 		panic(err)
 	}
@@ -1104,6 +1128,7 @@ func (k keypairs) findPairForSpecificRound(round uint64) merklesignature.KeyRoun
 
 func TestDeleteStateProofKeys(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	t.Parallel()
 	a := require.New(t)
 	registry, dbfile := getRegistry(t)
 	defer registryCloseTest(t, registry, dbfile)
@@ -1173,11 +1198,12 @@ func TestDeleteStateProofKeys(t *testing.T) {
 // test that sets up an error that should come up while flushing, and ensures that flush resets the last error
 func TestFlushResetsLastError(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	t.Parallel()
 	a := assert.New(t)
 	registry, dbfile := getRegistry(t)
 	defer registryCloseTest(t, registry, dbfile)
 
-	access, err := db.MakeAccessor("stateprooftest", false, true)
+	access, err := db.MakeAccessor(t.Name()+"_stateprooftest", false, true)
 	a.NoError(err)
 
 	root, err := GenerateRoot(access)
@@ -1211,6 +1237,7 @@ func TestFlushResetsLastError(t *testing.T) {
 // Makes sure the table is not locked for reading while a different one is locked for writing.
 func TestParticipationDB_Locking(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	t.Parallel()
 	a := require.New(t)
 
 	dbName := strings.Replace(t.Name(), "/", "_", -1)
@@ -1281,6 +1308,7 @@ func TestParticipationDB_Locking(t *testing.T) {
 
 func TestParticipationDBInstallWhileReading(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	t.Parallel()
 	a := require.New(t)
 
 	if testing.Short() {

data/account/participation_test.go

@@ -40,6 +40,7 @@ var partableColumnNames = [...]string{"parent", "vrf", "voting", "stateProof", "
 
 func TestParticipation_NewDB(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	t.Parallel()
 
 	a := require.New(t)
 
@@ -115,6 +116,7 @@ func getSchemaVersions(db db.Accessor) (versions map[string]int, err error) {
 
 func TestOverlapsInterval(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	t.Parallel()
 
 	const before = basics.Round(95)
 	const start = basics.Round(100)
@@ -189,6 +191,7 @@ func BenchmarkOldKeysDeletion(b *testing.B) {
 
 func TestRetrieveFromDB(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	t.Parallel()
 	a := require.New(t)
 	part, rootDB, partDB, err := setupParticipationKey(t, a)
 	a.NoError(err)
@@ -205,6 +208,7 @@ func TestRetrieveFromDB(t *testing.T) {
 
 func TestRetrieveFromDBAtVersion1(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	t.Parallel()
 
 	a := require.New(t)
 	ppart := setupkeyWithNoDBS(t, a)
@@ -227,6 +231,7 @@ func TestRetrieveFromDBAtVersion1(t *testing.T) {
 
 func TestRetrieveFromDBAtVersion2(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	t.Parallel()
 
 	a := require.New(t)
 
@@ -256,6 +261,7 @@ func TestRetrieveFromDBAtVersion2(t *testing.T) {
 
 func TestKeyRegCreation(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	t.Parallel()
 
 	a := require.New(t)
 
@@ -289,6 +295,7 @@ func assertionForRestoringFromDBAtLowVersion(a *require.Assertions, retrivedPart
 
 func TestMigrateFromVersion1(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	t.Parallel()
 
 	a := require.New(t)
 	part := setupkeyWithNoDBS(t, a).Participation
@@ -304,6 +311,7 @@ func TestMigrateFromVersion1(t *testing.T) {
 
 func TestMigrationFromVersion2(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	t.Parallel()
 
 	a := require.New(t)
 	part := setupkeyWithNoDBS(t, a).Participation
@@ -498,6 +506,7 @@ func createMerkleSignatureSchemeTestDB(a *require.Assertions) *db.Accessor {
 
 func TestKeyregValidityOverLimit(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	t.Parallel()
 	a := require.New(t)
 
 	maxValidPeriod := config.Consensus[protocol.ConsensusCurrentVersion].MaxKeyregValidPeriod
@@ -516,6 +525,7 @@ func TestKeyregValidityOverLimit(t *testing.T) {
 
 func TestFillDBWithParticipationKeys(t *testing.T) {
 	partitiontest.PartitionTest(t)
+	t.Parallel()
 	a := require.New(t)
 
 	dilution := config.Consensus[protocol.ConsensusCurrentVersion].DefaultKeyDilution
@@ -531,7 +541,7 @@ func TestFillDBWithParticipationKeys(t *testing.T) {
 	a.NoError(err)
 }
 
-func TestKeyregValidityPeriod(t *testing.T) {
+func TestKeyregValidityPeriod(t *testing.T) { //nolint:paralleltest // Not parallel because it modifies config.Consensus
 	partitiontest.PartitionTest(t)
 	a := require.New(t)