scripts(compute_branch): fix incorrect conditional #4987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algolucky
requested review from
algonautshant,
onetechnical,
a team,
excalq,
algobarb and
algojack
algolucky
changed the title
onetechnical
previously approved these changes
Jan 9, 2023
algorandskiy
reviewed
Jan 9, 2023
There was a problem hiding this comment.
Please rebase on top of master, TestREDCongestionManagerShouldntDrop fixed in #4986
algolucky
force-pushed
the
fix/compute-branch-condition
branch
from
51a0f07 to
5988867
Compare
onetechnical
approved these changes
Jan 9, 2023
Codecov Report
@@ Coverage Diff @@
## master #4987 +/- ##
=======================================
Coverage 53.62% 53.62%
=======================================
Files 432 432
Lines 54048 54048
=======================================
Hits 28985 28985
Misses 22814 22814
Partials 2249 2249 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
algorandskiy
approved these changes
Jan 9, 2023
winder
pushed a commit
to winder/go-algorand
that referenced
this pull request
Jan 18, 2023
This was referenced Jan 23, 2023
This was referenced Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
this was introduced in #4927
-zoperator, otherwise it works opposite as it was intended.Test Plan
Executing
make buildyou should see the-X github.com/algorand/go-algorand/config.Branch=fix/compute-branch-conditionthis is what we see on
rel/nightly(it's empty)