Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tech debt: Remove unused NetworkFetcher. #5028

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

winder
Copy link
Contributor

@winder winder commented Jan 18, 2023

Summary

We ended up not using this feature, so no need to maintain the code.

Test Plan

Existing regression tests.

@winder winder requested a review from cce January 18, 2023 21:28
@winder winder self-assigned this Jan 18, 2023
@winder winder changed the title NetworkFetcher is no longer needed. tech debt: Remove unused NetworkFetcher. Jan 18, 2023
@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Merging #5028 (c75518b) into master (4631571) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5028      +/-   ##
==========================================
- Coverage   53.68%   53.61%   -0.08%     
==========================================
  Files         432      431       -1     
  Lines       54068    54013      -55     
==========================================
- Hits        29029    28961      -68     
- Misses      22793    22803      +10     
- Partials     2246     2249       +3     
Impacted Files Coverage Δ
ledger/roundlru.go 90.56% <0.00%> (-5.67%) ⬇️
ledger/blockqueue.go 85.63% <0.00%> (-2.88%) ⬇️
network/wsPeer.go 66.43% <0.00%> (-2.37%) ⬇️
crypto/merkletrie/trie.go 66.42% <0.00%> (-2.19%) ⬇️
crypto/merkletrie/node.go 91.62% <0.00%> (-1.87%) ⬇️
catchup/universalFetcher.go 94.96% <0.00%> (-1.26%) ⬇️
cmd/tealdbg/debugger.go 72.69% <0.00%> (-0.81%) ⬇️
catchup/service.go 70.04% <0.00%> (-0.49%) ⬇️
ledger/acctupdates.go 69.24% <0.00%> (+0.24%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@winder winder marked this pull request as ready for review January 19, 2023 18:24
@winder winder merged commit 5dd909c into algorand:master Jan 19, 2023
@winder winder deleted the will/cleanup-network-fetcher branch January 19, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants