Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Remove accidental devtesting output. #5033

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

winder
Copy link
Contributor

@winder winder commented Jan 19, 2023

Summary

Copy link
Contributor

@algobarb algobarb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@winder winder changed the title Remove accidental devtesting output. bugfix: Remove accidental devtesting output. Jan 19, 2023
@winder winder self-assigned this Jan 19, 2023
@winder winder marked this pull request as ready for review January 19, 2023 18:22
@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Merging #5033 (96dbb18) into master (e01e374) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5033      +/-   ##
==========================================
+ Coverage   53.62%   53.66%   +0.04%     
==========================================
  Files         431      431              
  Lines       53998    53998              
==========================================
+ Hits        28954    28977      +23     
+ Misses      22803    22781      -22     
+ Partials     2241     2240       -1     
Impacted Files Coverage Δ
crypto/merkletrie/trie.go 66.42% <0.00%> (-2.19%) ⬇️
crypto/merkletrie/node.go 91.62% <0.00%> (-1.87%) ⬇️
network/wsNetwork.go 64.74% <0.00%> (-0.27%) ⬇️
cmd/tealdbg/debugger.go 73.49% <0.00%> (+0.80%) ⬆️
catchup/peerSelector.go 100.00% <0.00%> (+1.04%) ⬆️
catchup/service.go 69.80% <0.00%> (+1.20%) ⬆️
network/wsPeer.go 68.79% <0.00%> (+2.36%) ⬆️
ledger/blockqueue.go 88.50% <0.00%> (+2.87%) ⬆️
ledger/tracker.go 78.05% <0.00%> (+3.79%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@algobarb
Copy link
Contributor

If we were to create a unit test to check the goal status output format, which folder/file can it be placed in?

@algorandskiy
Copy link
Contributor

maybe goalNodeTest.exp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants