Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

goal: fix for goal node status crash - no longer getting block #5100

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

mciccarello
Copy link
Contributor

@mciccarello mciccarello commented Feb 2, 2023

Summary

Avoid extra call to ledger.BlockHdr. It is unnecessary and seemed to lead to a crash in some edge cases.

@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Merging #5100 (5910a0a) into master (a1eaafb) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #5100      +/-   ##
==========================================
- Coverage   53.48%   53.47%   -0.01%     
==========================================
  Files         429      429              
  Lines       54041    54037       -4     
==========================================
- Hits        28905    28898       -7     
+ Misses      22890    22889       -1     
- Partials     2246     2250       +4     
Impacted Files Coverage Δ
daemon/algod/api/server/v2/handlers.go 0.82% <0.00%> (+<0.01%) ⬆️
crypto/merkletrie/trie.go 66.42% <0.00%> (-2.19%) ⬇️
agreement/cryptoVerifier.go 67.60% <0.00%> (-2.12%) ⬇️
agreement/proposalManager.go 96.07% <0.00%> (-1.97%) ⬇️
crypto/merkletrie/node.go 91.62% <0.00%> (-1.87%) ⬇️
catchup/peerSelector.go 98.95% <0.00%> (-1.05%) ⬇️
ledger/catchpointtracker.go 57.70% <0.00%> (-0.80%) ⬇️
network/wsNetwork.go 64.74% <0.00%> (-0.18%) ⬇️
ledger/testing/randomAccounts.go 56.26% <0.00%> (+0.61%) ⬆️
network/wsPeer.go 68.32% <0.00%> (+1.89%) ⬆️
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mciccarello mciccarello changed the title fix for goal node status crash - no longer getting block bug fix: fix for goal node status crash - no longer getting block Feb 2, 2023
Copy link
Contributor

@almog-t almog-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@winder winder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran some manual tests and this seems to work fine.

@winder winder changed the title bug fix: fix for goal node status crash - no longer getting block goal: fix for goal node status crash - no longer getting block Feb 2, 2023
@winder winder merged commit 9ffa72a into algorand:master Feb 2, 2023
algolucky pushed a commit to algolucky/go-algorand that referenced this pull request Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants