-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
goal: fix for goal node status crash - no longer getting block #5100
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5100 +/- ##
==========================================
- Coverage 53.48% 53.47% -0.01%
==========================================
Files 429 429
Lines 54041 54037 -4
==========================================
- Hits 28905 28898 -7
+ Misses 22890 22889 -1
- Partials 2246 2250 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran some manual tests and this seems to work fine.
Summary
Avoid extra call to
ledger.BlockHdr
. It is unnecessary and seemed to lead to a crash in some edge cases.