Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kv: add StorageEngine config #5369

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Conversation

icorderi
Copy link
Contributor

@icorderi icorderi commented May 9, 2023

Summary

We are breaking down #5212 in several smaller PRs to make it more digestible.

This first PR add a storage engine config.
The config version is bumped to v28.

This is built on top of the following PRs:

Test Plan

existing tests.

@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #5369 (20bcd53) into master (25eb57c) will decrease coverage by 4.58%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5369      +/-   ##
==========================================
- Coverage   55.40%   50.82%   -4.58%     
==========================================
  Files         447      447              
  Lines       63218    79537   +16319     
==========================================
+ Hits        35025    40427    +5402     
- Misses      25803    36718   +10915     
- Partials     2390     2392       +2     
Impacted Files Coverage Δ
config/localTemplate.go 51.94% <ø> (-8.66%) ⬇️

... and 417 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@icorderi icorderi requested a review from algonautshant May 9, 2023 17:59
Copy link
Contributor

@AlgoAxel AlgoAxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simply adds StorageEngine to the config and upgrades dependencies.

@algorandskiy algorandskiy changed the title feat: kv impl (1 of n) kv: add StorageEngine config Jun 2, 2023
@algorandskiy algorandskiy merged commit 76942c4 into algorand:master Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants