CICD: Macos dependencies #5618
Merged
CICD: Macos dependencies #5618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5618 +/- ##
==========================================
- Coverage 54.95% 54.94% -0.01%
==========================================
Files 460 460
Lines 64446 64446
==========================================
- Hits 35417 35411 -6
- Misses 26653 26657 +4
- Partials 2376 2378 +2 see 12 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
onetechnical
approved these changes
Jul 28, 2023
algorandskiy
approved these changes
Jul 28, 2023
This was referenced Aug 17, 2023
This was referenced Aug 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
CircleCI's amd64 machine are missing certain packages when we upgraded to 14.2.0. This change removes the conditional and will install and upgrade when we run the jobs on mac os machines each time.
Observed Behavior
During the mac_amd64 upgrade from xcode 13.2.1 to 14.2.0 (#5590 ), we had installed all of the packages by removing this conditional and running it once before reverting back the change. It seems to have cached the installed packages for a few days (7 days). However after a week we see this error
automake is required, but wasn't found on this systemagain in our nightly builds.The behavior seen in #2608 no longer seems to be true for CircleCI's xcode 14.2.0 machine.
Test Plan
Test that mac_amd64 build succeeds:
https://app.circleci.com/pipelines/github/algorand/go-algorand/15737/workflows/ea33bcc1-7654-4505-b7a7-ff8c959e89ac