tools: additional generator lifecycle logging. #5627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzaffi
reviewed
Aug 2, 2023
tzaffi
previously approved these changes
Aug 2, 2023
Codecov Report
@@ Coverage Diff @@
## master #5627 +/- ##
==========================================
- Coverage 55.06% 55.01% -0.06%
==========================================
Files 465 465
Lines 64584 64584
==========================================
- Hits 35561 35528 -33
- Misses 26652 26671 +19
- Partials 2371 2385 +14 see 12 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
shiqizng
approved these changes
Aug 2, 2023
This was referenced Aug 17, 2023
This was referenced Aug 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Generator seemed to hang for a test I was running. The report appears to have been created but for some reason the next job did not start. The goal of this additional lifecycle logging is to provide more information to the user about what is happening.