-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ledger: Close the ledger at node shutdown #5668
Ledger: Close the ledger at node shutdown #5668
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5668 +/- ##
==========================================
+ Coverage 55.15% 55.17% +0.02%
==========================================
Files 465 465
Lines 65024 65025 +1
==========================================
+ Hits 35862 35877 +15
+ Misses 26769 26759 -10
+ Partials 2393 2389 -4
... and 12 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems pretty innocuous, although ledger.Close()
does kick off a lot of previously unexecuted locks and waits. but closing releases a lot of resources and was probably part the original lifecycle design.
This reverts commit 8f840c7.
The ledger is never closed. This closes the ledger when shutting down the node.