p2p: remove TestP2PThreeNodesEvenDist #5736
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently theTestP2PThreeNodesEvenDist
fails pretty regularly. The theory here is that part of the problem is that P2P stream connections take longer to setup than the wsNetwork and that because of that nodes get into a bad state with consensus trying to move too quickly. The errors on the CI runs for these tests indicate that nodes are trying to catchup via gossip protocol but these attempts fail on timeouts.After further investigation it looks like this behavior is not specific to P2P but happens on the websocket network as well. 50~60% of the time the test takes significantly longer locally but still succeeds. The failure on the CircleCI side is likely just different resourcing leading to slower execution and slower recovery from the bad state that nodes get into. Removing the test for now.
FWIW P2P does pass the PartitionRecovery tests where this network template is used on the websocket network side.
Test Plan
This is a test only change. We want to see whether this change stops the existing test from being so flaky while discussing options to make it more stable and support the faster lambda.This only removes a flaky test, it should hopefully bring nightly builds back into a stable state.