tests: fix flaky simulate test #5738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cce
approved these changes
Sep 13, 2023
Codecov Report
@@ Coverage Diff @@
## master #5738 +/- ##
==========================================
- Coverage 55.59% 55.55% -0.04%
==========================================
Files 476 476
Lines 66853 66853
==========================================
- Hits 37165 37143 -22
- Misses 27169 27189 +20
- Partials 2519 2521 +2 see 10 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TestSimulateStartRound flaked because it expects txn simulated execution failed at round 1 after catching up to round 7 but time to time ledger is delayed flushing most recent deltas and it has all the state at round 1 needed for simulated execution so the simulate succeeds.
Use
Eventuallyto retry few times and give the ledger change to flush.Test Plan
This is a test fix.