-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker: Do not catchup if already initialized. #5756
Conversation
8147317
to
91b5f58
Compare
Codecov Report
@@ Coverage Diff @@
## master #5756 +/- ##
==========================================
- Coverage 55.47% 55.46% -0.02%
==========================================
Files 473 473
Lines 66682 66682
==========================================
- Hits 36995 36984 -11
- Misses 27175 27182 +7
- Partials 2512 2516 +4
... and 17 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
91b5f58
to
55538e6
Compare
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do we manage the releases so this doesn't get run against old algods?
@jannotti the docker image and algod are released and packaged together, so it isn't an issue. |
Summary
Avoid running fast catchup in docker containers which have already been initialized.
Test Plan
algorand/algod:3.18.0-stable
.