Tests: Address flakiness with TestMergePrimarySecondaryRelayAddressListsPartialOverlap #5758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tsPartialOverlap to minimize flakiness.
algorandskiy
approved these changes
Sep 26, 2023
Codecov Report
@@ Coverage Diff @@
## master #5758 +/- ##
=======================================
Coverage 55.47% 55.48%
=======================================
Files 473 473
Lines 66682 66682
=======================================
+ Hits 36995 36996 +1
- Misses 27175 27176 +1
+ Partials 2512 2510 -2 see 16 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This was referenced Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TestMergePrimarySecondaryRelayAddressListsPartialOverlap inconsistently passes on the build server - it seems there are some random DNS combos that are not compatible with our filtering. Given we have control over the SRV record naming convention, rather than debug these corner cases the test has been modified to better reflect patterns we actively support.
Test Plan
Ran TestMergePrimarySecondaryRelayAddressListsPartialOverlap several consecutive times locally - Rapid has been removed for this test so it also runs much faster.