Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix scripts/create_and_deploy_recipe.sh build #5764

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

algorandskiy
Copy link
Contributor

@algorandskiy algorandskiy commented Sep 28, 2023

Summary

Fix binaries build for local cluster deployment with docker.
Some errors seen are:

 > [9/9] RUN scripts/configure_dev-deps.sh && make clean && find tmp && tmp/pavel-5rel-arch/deploy_linux_version_exec.sh:
0.255 /bin/sh: 1: make: not found
...

37.18 /usr/bin/env: 'python3': No such file or directory
37.52 + '[' 3.19. = '' ']'
37.54 + export BUILDNUMBER=
37.54 + BUILDNUMBER=
37.54 + '[' '' = '' ']'
37.54 FULLVERSION does not appear to be valid: 3.19.
37.54 + echo 'FULLVERSION does not appear to be valid: 3.19.'
37.54 + exit 1

Additionally, fix ._Wallet hidden files in tar archive with export COPYFILE_DISABLE=true as per this post
Otherwise algod is trying to load these metadata files and fails with

{"file":"main.go","function":"main.run","level":"error","line":326,"msg":"couldn't initialize the node: AlgorandFullNode.loadParticipationKeys: cannot load db ._Wallet2.0.30000.partkey: file is not a database","time":"2023-09-28T19:40:02.936041Z"}

when starting with a dir containing

-rw-rw-r-- 1 ubuntu ubuntu    163 Sep 28 19:39 ._Wallet2.0.30000.partkey
-rw-rw-r-- 1 ubuntu ubuntu    163 Sep 28 19:39 ._Wallet2.rootkey
-rw-rw-r-- 1 ubuntu ubuntu 585728 Sep 28 19:39 Wallet2.0.30000.partkey
-rw-rw-r-- 1 ubuntu ubuntu   8192 Sep 28 19:39 Wallet2.rootkey

Test Plan

Local build with ./scripts/create_and_deploy_recipe.sh -c $NETWORK_NAME --recipe test/testdata/deployednettemplates/recipes/custom/recipe.json -r ~/networks/$NETWORK_NAME -b $S3_RELEASE_BUCKET succeeded.

onetechnical
onetechnical previously approved these changes Sep 28, 2023
Copy link
Contributor

@onetechnical onetechnical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay, though I would often use build-essential instead of make & g++.

@winder winder changed the title docker: fix scripts/create_and_deploy_recipe.sh build ci: fix scripts/create_and_deploy_recipe.sh build Sep 28, 2023
winder
winder previously approved these changes Sep 28, 2023
Copy link
Contributor

@winder winder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I just changed the title tag to "ci" instead of "docker".

@algorandskiy
Copy link
Contributor Author

Looks like there is another issue with hidden ._Wallet files that also needs to be addressed.

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #5764 (812a767) into master (91604df) will increase coverage by 0.02%.
Report is 3 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5764      +/-   ##
==========================================
+ Coverage   55.46%   55.48%   +0.02%     
==========================================
  Files         473      473              
  Lines       66682    66682              
==========================================
+ Hits        36986    37001      +15     
+ Misses      27178    27168      -10     
+ Partials     2518     2513       -5     

see 11 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@algorandskiy algorandskiy merged commit 79fb8fe into algorand:master Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants