-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: fix scripts/create_and_deploy_recipe.sh build #5764
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems okay, though I would often use build-essential instead of make & g++.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. I just changed the title tag to "ci" instead of "docker".
Looks like there is another issue with hidden |
812a767
ced2339
to
812a767
Compare
Codecov Report
@@ Coverage Diff @@
## master #5764 +/- ##
==========================================
+ Coverage 55.46% 55.48% +0.02%
==========================================
Files 473 473
Lines 66682 66682
==========================================
+ Hits 36986 37001 +15
+ Misses 27178 27168 -10
+ Partials 2518 2513 -5 see 11 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Summary
Fix binaries build for local cluster deployment with docker.
Some errors seen are:
Additionally, fix
._Wallet
hidden files in tar archive withexport COPYFILE_DISABLE=true
as per this postOtherwise algod is trying to load these metadata files and fails with
when starting with a dir containing
Test Plan
Local build with
./scripts/create_and_deploy_recipe.sh -c $NETWORK_NAME --recipe test/testdata/deployednettemplates/recipes/custom/recipe.json -r ~/networks/$NETWORK_NAME -b $S3_RELEASE_BUCKET
succeeded.