Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding graviton logo and badges #27

Merged
merged 4 commits into from
Jul 16, 2022
Merged

Adding graviton logo and badges #27

merged 4 commits into from
Jul 16, 2022

Conversation

aorumbayev
Copy link
Contributor

Proposed changes

  • Adds 2 variations on a proposal for graviton logo inspired by this diagram. Main readme contains colored gradient background (teal and green from algorand's website), and tutorial page is reversed black background and gradient on text itself.
  • I noticed that markdownlint is used so i had to add one extra disable for a rule that would prevent having header image as a first content in md file. If you'd like to follow the convention though - feel free to to suggest moving text above the icon.
  • Images are hosted on ipfs and here is a .psd version also on ipfs -> ipfs://QmVcS8ULiEUrzs3m6bFQncuRt4MUV8ydnJmyen2wWCt5uq, should be possible to download it and edit in photoshop further if needed.
  • Lastly adds 2 tiny repo badges (visitors count and link to algorand website), could be used as a starter template in case you wanna add more badges (like coverage, ci status and etc) in future.

@CLAassistant
Copy link

CLAassistant commented Jul 15, 2022

CLA assistant check
All committers have signed the CLA.

@tzaffi tzaffi mentioned this pull request Jul 15, 2022
* thanks and bump the version

* version bump
Co-authored-by: Zeph Grunschlag <[email protected]>
Copy link
Contributor

@tzaffi tzaffi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this great addition!!!!

@aorumbayev
Copy link
Contributor Author

aorumbayev commented Jul 16, 2022

@tzaffi btw this is offtopic, i've noticed you guys manually install the docker-compose in the default ubuntu 20 github actions worker. I suppose there is a need on your side to rely on particular docker compose version or its somehow tied to that sandbox custom github action. But if not, check out the list of tools that are already pre-installed into github actions workers (specifically ubuntu-latest), docker and docker-compose are already installed on these workers, so you can potentially simplify the ci file a bit -> https://github.com/actions/virtual-environments/blob/main/images/linux/Ubuntu2004-Readme.md#tools

@tzaffi
Copy link
Contributor

tzaffi commented Jul 16, 2022

@tzaffi btw this is offtopic, i've noticed you guys manually install the docker-compose in the default ubuntu 20 github actions worker. I suppose there is a need on your side to rely on particular docker compose version or its somehow tied to that sandbox custom github action. But if not, check out the list of tools that are already pre-installed into github actions workers (specifically ubuntu-latest), docker and docker-compose are already installed on these workers, so you can potentially simplify the ci file a bit -> https://github.com/actions/virtual-environments/blob/main/images/linux/Ubuntu2004-Readme.md#tools

Thanks. I've created #29 as a follow up.

@aorumbayev
Copy link
Contributor Author

@tzaffi awesome, thanks for offloading this to a gh issue!

But otherwise, will await for you to merge, unless there are any extra comments for the pr 👍

@tzaffi tzaffi merged commit 4af3ea7 into algorand:main Jul 16, 2022
@aorumbayev aorumbayev deleted the logo branch July 16, 2022 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants