Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dryrun cost #33

Merged
merged 16 commits into from
Nov 4, 2022
Merged

Dryrun cost #33

merged 16 commits into from
Nov 4, 2022

Conversation

tzaffi
Copy link
Contributor

@tzaffi tzaffi commented Oct 31, 2022

Upgrade the treatment of Dry Run Cost + Handle dryrun_accounts

This continues the almost ready to merge #31

Original PR Description

For certain use cases, it's necessary to set the balance of the app account to some nonzero value. One example is testing inner app calls. This PR allows the users to set balances for accounts and updates the existing dryrun cost field (which is now deprecated) and adds support for the new cost fields BudgetAdded and BudgetConsumed.

Testing: Unit tests.

Copy link
Contributor

@michaeldiamant michaeldiamant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tzaffi Thanks for picking up the effort here - Looks good to me. Consider my remarks optional.

@tzaffi tzaffi merged commit 2c562cc into main Nov 4, 2022
@tzaffi tzaffi deleted the dryrun_cost branch November 4, 2022 18:32
@tzaffi tzaffi mentioned this pull request Dec 6, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants