Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set pgsql exporter round from db on init #1177

Merged

Conversation

Eric-Warehime
Copy link
Contributor

Summary

Same change that was made for the noop exporter in #1176

We want to set the exporter's round based on the expected state so that the pipeline knows which round to start on.

Test Plan

Dummy Db always returns round 0, so there's not a great way to unit test this built in currently.

@Eric-Warehime Eric-Warehime added Not-Yet-Enabled Feature is not yet enabled at this time Skip-Release-Notes Reserved for PRs which do not need to be included in Release Notes labels Aug 12, 2022
@codecov
Copy link

codecov bot commented Aug 12, 2022

Codecov Report

❗ No coverage uploaded for pull request base (conduit@34986db). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             conduit    #1177   +/-   ##
==========================================
  Coverage           ?   60.61%           
==========================================
  Files              ?       59           
  Lines              ?     8635           
  Branches           ?        0           
==========================================
  Hits               ?     5234           
  Misses             ?     2936           
  Partials           ?      465           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Eric-Warehime Eric-Warehime merged commit 959c576 into algorand:conduit Aug 12, 2022
@Eric-Warehime Eric-Warehime deleted the postgres-exporter-round branch August 12, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Not-Yet-Enabled Feature is not yet enabled at this time Skip-Release-Notes Reserved for PRs which do not need to be included in Release Notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants