Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update submodule, oapi-codegen #1341

Merged
merged 4 commits into from
Nov 23, 2022

Conversation

Eric-Warehime
Copy link
Contributor

Summary

In order to update the go-algorand submodule there were a bunch of changes.

  • Updating dependencies in go.mod since go-algorand has bumped these same deps
  • Changing block-generator's imports of the algod models
  • Updating the oapi-codegen usage for the Indexer APIs. The newer version of the generator caused some type aliases to be created where there previously was none, and changed one of the error messages for 400 responses.

Test Plan

No new functionality added, so all existing CI/release testing applies.

Copy link
Contributor

@excalq excalq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, with discussion of WIP lint tests in our slack thread.

@Eric-Warehime
Copy link
Contributor Author

Added a few commits:

  • Updated circleCI and the make lint command to use golangci-lint
  • Various import order changes, spelling fix, etc. that were failing the new lints
  • Final fixes for the code gen changes to fix failing tests.

@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

❗ No coverage uploaded for pull request base (release/2.15.0@f16b682). Click here to learn what that means.
The diff coverage is n/a.

@@                Coverage Diff                @@
##             release/2.15.0    #1341   +/-   ##
=================================================
  Coverage                  ?   65.05%           
=================================================
  Files                     ?       52           
  Lines                     ?     8311           
  Branches                  ?        0           
=================================================
  Hits                      ?     5407           
  Misses                    ?     2431           
  Partials                  ?      473           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Eric-Warehime Eric-Warehime marked this pull request as ready for review November 23, 2022 20:49
@winder
Copy link
Contributor

winder commented Nov 23, 2022

Looks like this also addresses #1300 👍

Copy link
Contributor

@algobarb algobarb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mainly am checking that it passes the CircleCI tests and the package build. They LGTM.

@excalq excalq merged commit 349f09c into algorand:release/2.15.0 Nov 23, 2022
This was referenced Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants