-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conduit: Pass data dir to plugin config. #1357
Conversation
939aeed
to
30c6ca7
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1357 +/- ##
===========================================
- Coverage 62.78% 62.71% -0.07%
===========================================
Files 76 77 +1
Lines 10377 10374 -3
===========================================
- Hits 6515 6506 -9
- Misses 3303 3308 +5
- Partials 559 560 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
33f3f4f
to
b43b0da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I don't see anything that directly conflicts with what I've done with the plugin config strings. However be aware I've changed how they are indented slightly to make it work with conduit init, and I am dependent on that particular format (which I'm not super happy about, but will take time to generalize)
Summary
Pass a data directory to plugins so that path arguments can be optional.
Test Plan
New unit tests.