Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conduit: Default to plugin data directory when possible. #1366

Merged
merged 3 commits into from
Dec 8, 2022

Conversation

winder
Copy link
Contributor

@winder winder commented Dec 6, 2022

Summary

Use the new plugin data directory as a default location for the local ledger and file writer.

Test Plan

New unit tests.

@winder winder added the Enhancement New feature or request label Dec 6, 2022
@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Merging #1366 (206dc3e) into develop (9267008) will increase coverage by 0.23%.
The diff coverage is 81.81%.

@@             Coverage Diff             @@
##           develop    #1366      +/-   ##
===========================================
+ Coverage    63.07%   63.30%   +0.23%     
===========================================
  Files           77       77              
  Lines        10477    10483       +6     
===========================================
+ Hits          6608     6636      +28     
+ Misses        3308     3281      -27     
- Partials       561      566       +5     
Impacted Files Coverage Δ
...it/plugins/processors/blockprocessor/initialize.go 64.81% <66.66%> (+0.92%) ⬆️
...ugins/processors/blockprocessor/block_processor.go 76.22% <80.00%> (+9.00%) ⬆️
...duit/plugins/exporters/filewriter/file_exporter.go 76.78% <100.00%> (+1.31%) ⬆️
idb/postgres/postgres.go 64.71% <0.00%> (-0.14%) ⬇️
fetcher/fetcher.go 63.98% <0.00%> (+1.27%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@winder winder assigned winder and unassigned mciccarello and Eric-Warehime Dec 8, 2022
@winder winder merged commit 003183a into algorand:develop Dec 8, 2022
@winder winder deleted the will/use-plugin-datadir branch December 8, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants