performance: Add /v2/blocks benchmark #1396
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1396 +/- ##
========================================
Coverage 65.36% 65.36%
========================================
Files 79 79
Lines 11283 11283
========================================
Hits 7375 7375
Misses 3342 3342
Partials 566 566 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
It would be useful to have a local pprof http endpoint to pull the heap. |
shiqizng
reviewed
Jan 11, 2023
| require.NoError(b, err) | ||
| prevBlockHeader = block.BlockHeader | ||
|
|
||
| err = proc(&rpcs.EncodedBlockCert{Block: block}) |
There was a problem hiding this comment.
this test breaks after block_processor is refactored to query the state deltas.
|
Closing because the test would soon become obsolete. It depends on the block processor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
/v2/blocksendpoint consumes a large amount of memory when handling blocks with high transactions which have large numbers of inner transactions. This benchmarks memory usage of the API when processing different variations of transactions/inner transactions from a block.