Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Add a way to pause the e2e docker container for debugging. #1412

Merged
merged 2 commits into from
Jan 13, 2023

Conversation

winder
Copy link
Contributor

@winder winder commented Jan 11, 2023

Summary

I frequently find myself wanting to inspect the e2elive temp files in the docker container. These changes allow you to do so by setting export EXTRA=--keep-alive prior to running make e2e.

Test Plan

Manual testing.

@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Merging #1412 (419ffe3) into develop (34d18c6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1412   +/-   ##
========================================
  Coverage    65.39%   65.39%           
========================================
  Files           79       79           
  Lines        11283    11283           
========================================
  Hits          7378     7378           
  Misses        3340     3340           
  Partials       565      565           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@winder winder added the Enhancement New feature or request label Jan 13, 2023
@winder winder requested a review from tzaffi January 13, 2023 14:16
@winder winder changed the title Add a way to pause the e2e docker container for debugging. tests: Add a way to pause the e2e docker container for debugging. Jan 13, 2023
Copy link
Contributor

@tzaffi tzaffi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winder winder merged commit dd496ed into algorand:develop Jan 13, 2023
@winder winder deleted the will/e2e-docker-debugging branch January 13, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants