Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Sourcemap mapping field deprecation #441

Merged
merged 4 commits into from
Dec 13, 2022
Merged

Enhancement: Sourcemap mapping field deprecation #441

merged 4 commits into from
Dec 13, 2022

Conversation

ahangsu
Copy link
Contributor

@ahangsu ahangsu commented Dec 12, 2022

@michaeldiamant michaeldiamant mentioned this pull request Dec 12, 2022
Closed
7 tasks
ahangsu
ahangsu commented Dec 13, 2022
View reviewed changes
algochoi
algochoi approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@algochoi algochoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good - since the test itself is not a breaking change, we could also target master for this PR right?

@ahangsu
Copy link
Contributor Author

ahangsu commented Dec 13, 2022

I think for now all the testing branches are targeting master?

@algochoi
Copy link
Contributor

Oh I mean this PR itself (currently targeting feature/v2.0.0-break)

@ahangsu
Copy link
Contributor Author

ahangsu commented Dec 13, 2022

I think it is part of #389, so I'm pointing to feature branch for now.

@ahangsu
Copy link
Contributor Author

ahangsu commented Dec 13, 2022

After more thoughts, I think you are right. If this PR does not go to master, then the current change of testcase might fail.

@ahangsu ahangsu changed the base branch from feature/v2.0.0-break to develop December 13, 2022 22:46
@ahangsu ahangsu changed the title Sourcemap mapping field deprecation Enhancement: Sourcemap mapping field deprecation Dec 13, 2022
@ahangsu ahangsu merged commit 893c47a into develop Dec 13, 2022
@ahangsu ahangsu deleted the sourcemap-mapping-deprecate branch December 13, 2022 22:49
@algolucky algolucky mentioned this pull request Jan 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@algochoi algochoi algochoi approved these changes

@michaeldiamant michaeldiamant Awaiting requested review from michaeldiamant

Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahangsu @algochoi