-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support inner transactions #115
Conversation
8a7e03e
to
91b146b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good to me. adding descriptions to the new classes, such as InnerTxnActionExpr, would be helpful. and what happened to the tests for gtxn/gtxnas?
I've just added documentation for inner transactions -- thank you for reminding me! The existing tests for txn/gtxn were very repetitive, so instead of repeating them again for itxn, I got rid of all the handwritten tests in favor of the new method |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
Closes #112
In addition to supporting inner transactions, this PR also:
Op
enumSeq
expressions (this is a no-op, but it's needed to supportInnerTxnBuilder.SetFields({})
)txn
,gtxn
,itxn
)