Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TimePicker2]TimePicker2 with specified format can only recognise full input #3651

Closed
ghost opened this issue Dec 28, 2021 · 1 comment · Fixed by #4803
Closed

[TimePicker2]TimePicker2 with specified format can only recognise full input #3651

ghost opened this issue Dec 28, 2021 · 1 comment · Fixed by #4803
Assignees
@YunMeng99
Labels
🐞 Bug Something isn't working Next release issues to close in next release

Comments

@ghost
Copy link

ghost commented Dec 28, 2021 •
edited by ghost
Loading

Component

TimePicker2

Steps to reproduce

When choosing custom format for TimePicker2,

the component won't help to select 12 when we just type "12", we will need to type in the full format "12:00:00" for TimePicker2 to recognise the time.

image

image
@lakerswgq lakerswgq self-assigned this Dec 29, 2021
@YunMeng99 YunMeng99 added the 💡 Feature Request New feature or request label Aug 11, 2023
@YSMJ1994 YSMJ1994 added 🐞 Bug Something isn't working and removed 💡 Feature Request New feature or request labels Feb 29, 2024
@YSMJ1994 YSMJ1994 added the Next release issues to close in next release label Feb 29, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in DAILY WORK Feb 29, 2024
@YSMJ1994
Copy link
Contributor

原因：https://github.com/alibaba-fusion/next/blob/master/components/time-picker2/time-picker.jsx#L405 此处写死了 format
修复方案：根据 props.format 来格式化输入字符串

YunMeng99 pushed a commit that referenced this issue Mar 27, 2024
fix(TimePicker2): should support custom formatting close ##3651
3129b2d
@YunMeng99 YunMeng99 linked a pull request Mar 27, 2024 that will close this issue
fix(TimePicker2): should support custom formatting close ##3651 #4803
Merged
@YunMeng99 YunMeng99 moved this from 🆕 New to 🏗 In progress in DAILY WORK Mar 28, 2024
@YunMeng99 YunMeng99 moved this from 🏗 In progress to 👀 In review in DAILY WORK Mar 28, 2024
YSMJ1994 pushed a commit that referenced this issue Apr 3, 2024
@YunMeng99
fix(TimePicker2): use props.format to validate value, close #3651 (#4803
aac4730 
)

* fix(TimePicker2): should support custom formatting close ##3651

* feat(TimePicker2): test case modification
@github-project-automation github-project-automation bot moved this from 👀 In review to Ready to release in DAILY WORK Apr 3, 2024
@YSMJ1994 YSMJ1994 moved this from Ready to release to ✅ Done in DAILY WORK Apr 3, 2024
eternalsky pushed a commit that referenced this issue Jul 16, 2024
@YunMeng99 @eternalsky
fix(TimePicker2): use props.format to validate value, close #3651 (#4803
8c8ead9 
)

* fix(TimePicker2): should support custom formatting close ##3651

* feat(TimePicker2): test case modification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YunMeng99 YunMeng99

Labels
🐞 Bug Something isn't working Next release issues to close in next release
Projects
DAILY WORK
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(TimePicker2): should support custom formatting close ##3651 alibaba-fusion/next
3 participants
@lakerswgq @YSMJ1994 @YunMeng99