Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Table]table组件库，主键值为0的情况提示报错 #3740

Closed
south-tree opened this issue Feb 14, 2022 · 0 comments · Fixed by #4791
Closed

[Table]table组件库，主键值为0的情况提示报错 #3740

south-tree opened this issue Feb 14, 2022 · 0 comments · Fixed by #4791
Assignees
@seven-lh
Labels
🐞 Bug Something isn't working improvement improve some features Next release issues to close in next release

Comments

@south-tree
Copy link

Component

Table

Steps to reproduce

主键的值为0的情况下会报错。
文件：es/table/selection.js
if (!id) {
log.warning('Can't get value from record using given ' primaryKey ' as primaryKey.');
}
@YunMeng99 YunMeng99 added improvement improve some features 🐞 Bug Something isn't working labels Aug 11, 2023
@YSMJ1994 YSMJ1994 assigned seven-lh and unassigned youluna Nov 3, 2023
seven-lh pushed a commit that referenced this issue Nov 8, 2023
fix(Table):table-selection-top-zreo-primaryKey-#3740
5f03978
@YSMJ1994 YSMJ1994 added the Next release issues to close in next release label Feb 29, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in DAILY WORK Feb 29, 2024
@YSMJ1994 YSMJ1994 added Easy to solve Easy to solve problems, PR welcome PR welcome We need you to help us by sending a pull request :) Next release issues to close in next release and removed Next release issues to close in next release PR welcome We need you to help us by sending a pull request :) Easy to solve Easy to solve problems, PR welcome labels Feb 29, 2024
@seven-lh seven-lh moved this from 🆕 New to 🏗 In progress in DAILY WORK Mar 15, 2024
seven-lh pushed a commit that referenced this issue Mar 20, 2024
fix(Table): DataSource Id zero console.warning on Check ##3740
Loading
Loading status checks…
29e7c21
@seven-lh seven-lh mentioned this issue Mar 20, 2024
Merged
@seven-lh seven-lh linked a pull request Mar 20, 2024 that will close this issue
fix(Table): DataSource Id zero console.warning on Check ##3740 #4791
Merged
seven-lh pushed a commit that referenced this issue Mar 20, 2024
fix(Table): DataSource Id zero console.warning on Check ##3740
Loading
Loading status checks…
b101ff3
@seven-lh seven-lh moved this from 🏗 In progress to 👀 In review in DAILY WORK Mar 20, 2024
seven-lh pushed a commit that referenced this issue Mar 20, 2024
fix(Table): DataSource id is zero console.warning on Check ##3740
Loading
Loading status checks…
648d251
seven-lh pushed a commit that referenced this issue Mar 20, 2024
fix(Table): DataSource id is zero console.warning on Check ##3740
Loading
Loading status checks…
5f6b4d7
seven-lh pushed a commit that referenced this issue Mar 20, 2024
fix(Table): DataSource id is zero console.warning on Check ##3740
Loading
Loading status checks…
0b918e9
eternalsky pushed a commit that referenced this issue Mar 20, 2024
@seven-lh
fix(Table): should not log warn when dataSource id is 0, close #3740 (#…
Loading
Loading status checks…
f7b8c8c 
…4791)

Co-authored-by: lancely <[email protected]>
@github-project-automation github-project-automation bot moved this from 👀 In review to Ready to release in DAILY WORK Mar 20, 2024
@YSMJ1994 YSMJ1994 moved this from Ready to release to ✅ Done in DAILY WORK Mar 22, 2024
eternalsky pushed a commit that referenced this issue Jul 16, 2024
@seven-lh @eternalsky
fix(Table): should not log warn when dataSource id is 0, close #3740 (#…
ee2b778 
…4791)

Co-authored-by: lancely <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seven-lh seven-lh

Labels
🐞 Bug Something isn't working improvement improve some features Next release issues to close in next release
Projects
DAILY WORK
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(Table): DataSource Id zero console.warning on Check ##3740 alibaba-fusion/next
5 participants
@seven-lh @south-tree @youluna @YSMJ1994 @YunMeng99