Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

关于Form组件device属性的讨论 #4513

Closed
lilithyang2018 opened this issue Nov 3, 2023 · 3 comments · Fixed by #4707
Closed

关于Form组件device属性的讨论 #4513

lilithyang2018 opened this issue Nov 3, 2023 · 3 comments · Fixed by #4707
Assignees
@YSMJ1994
Labels
🐞 Bug Something isn't working Next release issues to close in next release

Comments

@lilithyang2018
Copy link 

          > 你好，组件内有有很多相互调用的情况，针对可通过ConfigProvider配置的全局配置，我们不可能每次调用别的组件都forward这些配置，这边还是建议通过ConfigProvider来传递相关属性

是这样的 我的理解是 既然你的Form组件提供了device属性，你就应该让这个属性直接配置是有效的 而不是非要通过ConfigProvider来配置

form
要么Form组件就不要显示这个device属性

Originally posted by @lilithyang2018 in #4483 (comment)
@YSMJ1994
Copy link
Contributor

YSMJ1994 commented Nov 3, 2023

从这个点来看，以往的设计确实是有一些问题的，组件开放的属性与使用的实际表现有差异。但考虑到涉及面比较广，不仅仅是device这一个属性，很多别的可以通过全局配置的属性都有这个问题，我们会逐步跟进改造，使所有组件的开放属性与其实际表现一致。

@YSMJ1994 YSMJ1994 added the improvement improve some features label Nov 3, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2023

你好，该 issue 已 30 天没有活动，因此被标记为 stale，如果之后的 7 天仍然没有活动，该 issue 将被自动关闭

@github-actions github-actions bot added the Stale not active for a lone time label Dec 3, 2023
@YSMJ1994 YSMJ1994 added 🐞 Bug Something isn't working Next release issues to close in next release and removed Stale not active for a lone time 💬 Discussion improvement improve some features labels Dec 7, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in DAILY WORK Dec 7, 2023
@YSMJ1994 YSMJ1994 self-assigned this Dec 7, 2023
@YSMJ1994 YSMJ1994 moved this from 🆕 New to 🔖 Ready in DAILY WORK Dec 7, 2023
@YSMJ1994 YSMJ1994 linked a pull request Dec 12, 2023 that will close this issue
fix(ConfigProvider): configured component can pass common props to children automatically, close #4513 #4646
Closed
YSMJ1994 added a commit that referenced this issue Dec 12, 2023
@YSMJ1994
fix(ConfigProvider): configured component can pass common props to ch…
c452036 
…ildren automatically, close #4513
@YSMJ1994 YSMJ1994 moved this from 🔖 Ready to 👀 In review in DAILY WORK Dec 12, 2023
@YSMJ1994 YSMJ1994 moved this from 👀 In review to 📋 Backlog in DAILY WORK Dec 14, 2023
YSMJ1994 added a commit that referenced this issue Dec 14, 2023
@YSMJ1994
fix(Form): should pass common props to RGrid, close #4513
70b3e1c
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2024

你好，该 issue 已 30 天没有活动，因此被标记为 stale，如果之后的 7 天仍然没有活动，该 issue 将被自动关闭

@github-actions github-actions bot added the Stale not active for a lone time label Jan 6, 2024
@YSMJ1994 YSMJ1994 removed the Stale not active for a lone time label Jan 10, 2024
YSMJ1994 added a commit that referenced this issue Jan 10, 2024
@YSMJ1994
fix(Form): pass device to responsive-grid, close #4513
233c7da
@YSMJ1994 YSMJ1994 linked a pull request Jan 10, 2024 that will close this issue
fix(Form): pass device to responsive-grid, close #4513 #4707
Merged
YSMJ1994 added a commit that referenced this issue Jan 10, 2024
@YSMJ1994
fix(Form): pass device to responsive-grid, close #4513 (#4707)
110937b
@github-project-automation github-project-automation bot moved this from 📋 Backlog to Ready to release in DAILY WORK Jan 10, 2024
@YSMJ1994 YSMJ1994 moved this from Ready to release to ✅ Done in DAILY WORK Jan 15, 2024
eternalsky pushed a commit that referenced this issue Jul 16, 2024
@YSMJ1994 @eternalsky
fix(Form): pass device to responsive-grid, close #4513 (#4707)
3eef0af
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YSMJ1994 YSMJ1994

Labels
🐞 Bug Something isn't working Next release issues to close in next release
Projects
DAILY WORK
Archived in project
Milestone
No milestone
2 participants
@YSMJ1994 @lilithyang2018