Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Slider): correct arrow disabled state in some case, close #1065 #1067

Merged
merged 1 commit into from
Aug 29, 2019

Conversation

youluna
Copy link
Member

@youluna youluna commented Aug 29, 2019

No description provided.

@youluna youluna requested a review from myronliu347 August 29, 2019 02:59
@codecov
Copy link

codecov bot commented Aug 29, 2019

Codecov Report

Merging #1067 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1067      +/-   ##
==========================================
+ Coverage   91.43%   91.44%   +<.01%     
==========================================
  Files         248      248              
  Lines       14447    14445       -2     
  Branches     4568     4567       -1     
==========================================
- Hits        13210    13209       -1     
+ Misses       1218     1217       -1     
  Partials       19       19
Impacted Files Coverage Δ
src/slider/slick/arrow.jsx 100% <ø> (+2.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a631db4...a9b319b. Read the comment docs.

@myronliu347 myronliu347 merged commit 0ee86cd into alibaba-fusion:master Aug 29, 2019
@youluna youluna deleted the fix-slider-arrow-disable branch September 29, 2019 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants