Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Input): textarea should support hasClea close #4334 #4642

Closed
wants to merge 3 commits into from

Conversation

YunMeng99
Copy link
Contributor

No description provided.

@YunMeng99 YunMeng99 requested a review from YSMJ1994 December 11, 2023 08:52
@YunMeng99 YunMeng99 linked an issue Dec 11, 2023 that may be closed by this pull request
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (0fed23b) 90.76% compared to head (09dbe25) 90.95%.
Report is 25 commits behind head on master.

❗ Current head 09dbe25 differs from pull request most recent head 32c1725. Consider uploading reports for the commit 32c1725 to get more accurate results

Files Patch % Lines
src/input/textarea.jsx 65.21% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4642      +/-   ##
==========================================
+ Coverage   90.76%   90.95%   +0.19%     
==========================================
  Files         305      305              
  Lines       17903    18162     +259     
  Branches     5405     5378      -27     
==========================================
+ Hits        16249    16519     +270     
+ Misses       1637     1626      -11     
  Partials       17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@YSMJ1994 YSMJ1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. 参考issue#4334 内给出的视觉图片设计icon位置,把清除文本替换为 icon即可
  2. 需要在docs/input/demo/clear.md内补充 TextArea组件的 hasClear = true 的示例

@YunMeng99 YunMeng99 requested a review from YSMJ1994 December 13, 2023 05:08
@YSMJ1994
Copy link
Contributor

@YunMeng99

  1. 影响了input
  2. 与limitHint 不对齐
  3. 渲染逻辑需要优化,分隔符最好通过css after来实现

image

@YSMJ1994 YSMJ1994 closed this Dec 27, 2023
@YunMeng99 YunMeng99 deleted the feat/TextArea-hasClear branch January 10, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants