Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Checkbox): upgrade checkbox ts #4688

Merged
merged 4 commits into from
Mar 15, 2024
Merged

Conversation

liujuping
Copy link

@liujuping liujuping commented Dec 28, 2023

close #4574

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这是您为 Fusion/Next 提的第一个 pr,感谢您为 Fusion 做出的贡献,我们会尽快进行处理。

@liujuping liujuping force-pushed the feat/upgrade-checkbox-ts branch 3 times, most recently from ae2fd40 to c4e17f8 Compare December 28, 2023 07:47
@liujuping
Copy link
Author

依赖 Icon ts 化优化。

@YSMJ1994
Copy link
Contributor

YSMJ1994 commented Jan 5, 2024

  1. master 有更新,先合并一下吧
  2. 有不少 eslint 错误
  3. 类型里有太多any,需要根据实际代码不全
  4. 入口文件未导出组件 api 的类型
  5. jsdoc需要移除

@liujuping liujuping force-pushed the feat/upgrade-checkbox-ts branch 5 times, most recently from 7515739 to 229a66e Compare January 16, 2024 08:36
@liujuping
Copy link
Author

  1. master 有更新,先合并一下吧
  2. 有不少 eslint 错误
  3. 类型里有太多any,需要根据实际代码不全
  4. 入口文件未导出组件 api 的类型
  5. jsdoc需要移除

1、3、4 fixed。

2 没有看到

5 指的是什么?

@YSMJ1994
Copy link
Contributor

  1. master 有更新,先合并一下吧
  2. 有不少 eslint 错误
  3. 类型里有太多any,需要根据实际代码不全
  4. 入口文件未导出组件 api 的类型
  5. jsdoc需要移除

1、3、4 fixed。

2 没有看到

5 指的是什么?

npm run check:eslint checkbox 执行一下看看

Copy link

你好,该 pr 已 30 天没有活动,因此被标记为 stale,如果之后的 7 天仍然没有活动,该 pr 将被自动关闭

@github-actions github-actions bot added the Stale not active for a lone time label Feb 19, 2024
@eternalsky eternalsky removed the Stale not active for a lone time label Feb 21, 2024
@eternalsky eternalsky force-pushed the feat/upgrade-checkbox-ts branch from 229a66e to 3dac8fc Compare March 14, 2024 06:13
@eternalsky eternalsky force-pushed the feat/upgrade-checkbox-ts branch 5 times, most recently from a46cb92 to 437fa05 Compare March 14, 2024 12:52
@eternalsky eternalsky force-pushed the feat/upgrade-checkbox-ts branch from 437fa05 to 687547a Compare March 14, 2024 12:58
@eternalsky
Copy link
Contributor

done

@eternalsky eternalsky requested a review from YSMJ1994 March 15, 2024 07:52
@YSMJ1994 YSMJ1994 merged commit 6fcffd8 into master Mar 15, 2024
3 of 5 checks passed
@YSMJ1994 YSMJ1994 deleted the feat/upgrade-checkbox-ts branch March 15, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

【Technical upgrade】Checkbox
3 participants