Add checks for completeness of msg_handler #388
Conversation
rayrayraykk
changed the title
|
@xieyxclack Please help me check the |
federatedscope/core/fed_runner.py
Outdated
| Returns: | ||
|
|
||
| """ | ||
| if self.cfg.check_completeness: |
There was a problem hiding this comment.
I don't think it is necessary to indent such a huge block of code
There was a problem hiding this comment.
Update accordingly.
| f'check results in {fig_path}.') | ||
| except Exception as error: | ||
| logger.warning(f'Completeness check failed for {error}!') | ||
| return |
There was a problem hiding this comment.
so the reason is that we cannot say yes or not about the correctness/completeness, right?
There was a problem hiding this comment.
As the document shows, the correctness/completeness checks only check the message-handler pairs and raise three types of logs (info, warning, and error). If something goes wrong with Python code, we'd better keep the exception stack as it is. So the return value is meaningless.
|
DO NOT merge this PR ahead of #365 . |
As that pr has been merged, please resolve the conflicts so that we can close this thread. |
Main changes
Add a check for completeness of msg_handler in workers. (Required
networkxandmatplotliband I add them indevmode)What's New in worker
A
classmethod:get_msg_handler_dict;A
self.msg_handlers_strto store triplets <msg_in,handler_name,[msg_out0, msg_out1, ...]>How to use:
Set
cfg.check_completeness=True:What information will the user know:
If the checks are enabled, three types of info will show:
pass,warning,errorfor the case:And a DiGraph will be plotted in
exp_dirto remind users something might goes wrong:For pure FedAvg:
